Remove hook manager #4012
Merged
Remove hook manager #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
remove_hook_manager
branch
8 times, most recently
from
c020476
to
501b2ea
Compare
valentin-krasontovitsch
approved these changes
Oct 6, 2022
| @@ -50,6 +53,7 @@ ert_workflow_list_alloc_empty(const subst_list_type *context) { | |||
| workflow_list->joblist = workflow_joblist_alloc(); | |||
| workflow_list->context = context; | |||
| workflow_list->last_error = NULL; | |||
| workflow_list->hook_workflow_list = vector_alloc_new(); | |||
There was a problem hiding this comment.
you're planning to reimplement this in python when simplifying the workflow list, so i understand if this is not a priority. just wanted to mention that freeing the hook_workflow_list might be reasonable.
| continue | ||
|
|
||
| workflow = hook_workflow.getWorkflow() | ||
| for workflow in workflow_list.get_workflows_hooked_at(runtime): |
There was a problem hiding this comment.
nice and elegant. i like
| @@ -648,4 +647,6 @@ def test_that_workflow_run_modes_can_be_selected(tmp_path, run_mode): | |||
| f"HOOK_WORKFLOW SCRIPT {run_mode}\n" | |||
| ) | |||
| res_config = ResConfig(str(test_user_config)) | |||
| assert res_config.hook_manager[0].getRunMode() == run_mode | |||
| assert ( | |||
| len(list(res_config.ert_workflow_list.get_workflows_hooked_at(run_mode))) == 1 | |||
There was a problem hiding this comment.
much nicer!
| @@ -71,7 +71,6 @@ def test_site_config_hook_workflow(monkeypatch, tmp_path): | |||
| monkeypatch.setenv("ERT_SITE_CONFIG", site_config_filename) | |||
|
|
|||
| res_config = ResConfig(user_config_file=test_config_filename) | |||
| assert len(res_config.hook_manager) == 1 | |||
There was a problem hiding this comment.
you didn't replace this assertion with something equivalent, as far as i can see - you deemed it unnecessary to remain in the test?
There was a problem hiding this comment.
I added back a similar assertion just in case :)
eivindjahren
force-pushed
the
remove_hook_manager
branch
from
501b2ea
to
a53e8f5
Compare
eivindjahren
force-pushed
the
remove_hook_manager
branch
from
a53e8f5
to
000c47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves one of the items of #3986
Approach
The only part of hook manager that is used it the hook_workflow_list. This is really a map from workflow (time at which the workflow should run) to run_mode, telling ert when to run the workflow. Its probably a good idea to keep this information together with the workflows, ie. in
ert_workflow_list(which is next on the list for simplification, and now that hook manager is gone, ert_workflow_list can be reimplemented in python).Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.