Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate the DATA_FILE keyword and add documentation #4017

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Oct 6, 2022

Issue
Resolves #3937

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide self-assigned this Oct 6, 2022
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Merging #4017 (39c0790) into main (f4042c5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4017      +/-   ##
==========================================
- Coverage   58.32%   58.31%   -0.01%     
==========================================
  Files         526      526              
  Lines       39118    39110       -8     
  Branches     3444     3444              
==========================================
- Hits        22815    22807       -8     
- Misses      15423    15424       +1     
+ Partials      880      879       -1     
Impacted Files Coverage Δ
src/ert/_c_wrappers/enkf/res_config.py 93.81% <ø> (-0.14%) ⬇️
src/clib/lib/res_util/block_fs.cpp 66.66% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide merged commit 29fb7c5 into equinor:main Oct 17, 2022
@oyvindeide oyvindeide deleted the undeprecate branch May 2, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants