Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete site config c code #4020

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Delete site config c code #4020

merged 9 commits into from
Oct 19, 2022

Conversation

mortalisk
Copy link
Contributor

@mortalisk mortalisk commented Oct 7, 2022 •
edited by valentin-krasontovitsch

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@mortalisk mortalisk force-pushed the delete_site_config branch 7 times, most recently from eb67c26 to 7e69e62 Compare October 10, 2022 12:04
@mortalisk mortalisk marked this pull request as ready for review October 10, 2022 12:07
@mortalisk mortalisk self-assigned this Oct 10, 2022
@mortalisk mortalisk changed the title Delete site config Delete site config c code Oct 10, 2022
valentin-krasontovitsch
valentin-krasontovitsch previously requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@valentin-krasontovitsch valentin-krasontovitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of refactoring suggestions, questions / comments, and one actual sequence question : )

src/ert/_c_wrappers/enkf/res_config.py Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
DanSava
DanSava reviewed Oct 14, 2022
View reviewed changes
src/ert/_c_wrappers/enkf/res_config.py Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Outdated Show resolved Hide resolved
src/ert/_c_wrappers/enkf/site_config.py Show resolved Hide resolved
@mortalisk mortalisk force-pushed the delete_site_config branch 3 times, most recently from 1116824 to 66a8ef6 Compare October 18, 2022 15:18
eivindjahren
eivindjahren approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it now!

@eivindjahren eivindjahren merged commit 7c4b087 into equinor:main Oct 19, 2022
@oysteoh oysteoh mentioned this pull request Oct 21, 2022
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSava DanSava DanSava left review comments

@valentin-krasontovitsch valentin-krasontovitsch valentin-krasontovitsch left review comments

@andreas-el andreas-el andreas-el left review comments

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees

@mortalisk mortalisk

Labels
None yet
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mortalisk @DanSava @valentin-krasontovitsch @eivindjahren @andreas-el