Simplify ert config builder #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround for keeping res_config around together with enkf_main has not been needed for a long while, now res_config no longer has a c struct to keep around. Also, we can get and LibresFacade directly from config file.
Codecov Report
@@ Coverage Diff @@
## main #4022 +/- ##
=======================================
Coverage 58.73% 58.73%
=======================================
Files 539 539
Lines 40101 40101
Branches 3638 3638
=======================================
+ Hits 23554 23555 +1
+ Misses 15534 15533 -1
Partials 1013 1013
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oysteoh
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround for keeping res_config around together with enkf_main has not been needed for a long while, now res_config no longer has a c struct to keep around. Also, we can get and LibresFacade directly from config file.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.