Save parameters to in-memory storage between update-steps #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInFez
force-pushed
the
store_param_test_storage
branch
2 times, most recently
from
936f15f
to
ead7a12
Compare
ManInFez
force-pushed
the
store_param_test_storage
branch
3 times, most recently
from
6ad0ecd
to
e84553c
Compare
ManInFez
added
the
release-notes:improvement
dafeda
reviewed
Oct 10, 2022
| def _save_to_temporary_storage( | ||
| temporary_storage: Dict[str, "npt.NDArray[np.double]"], | ||
| parameters: List[update.Parameter], | ||
| A: Union["npt.NDArray[np.double]", None], |
There was a problem hiding this comment.
I think we should do what annotate-python-linting says here.
dafeda
reviewed
Oct 10, 2022
| @@ -9,16 +9,27 @@ def globalIndex(i, j, k, nx=10, ny=10): | |||
| return i + nx * (j - 1) + nx * ny * (k - 1) | |||
|
|
|||
|
|
|||
| def readParameters(filename): | |||
| def readSeed(filename): | |||
There was a problem hiding this comment.
Use pythonesque function names, i.e., read_seed?
With localization in ensemble smoother, intermediate update results was stored to disk. This entangled the usage of storage with running analysis. This commit keeps all parameters in memory while running analysis, and then persisting to disk when all steps are finished. Removing specialized functions for loading, saving and copying parameters Removing irrelevant tests
ManInFez
force-pushed
the
store_param_test_storage
branch
from
e84553c
to
050f5ac
Compare
|
test this please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With localization in ensemble smoother, intermediate update results was stored to disk. This entangled the usage of storage with running analysis. This commit keeps all parameters in memory while running analysis, and then persisting to disk when all steps are finished.
Removing specialized functions for loading, saving and copying parameters
Removing irrelevant tests
Issue
Resolves #3377
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.