Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests directories #4030

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Conversation

eivindjahren
Copy link
Contributor

There is no longer a split between ert and libres. The test directories should reflect that. This PR does the following renames

  • tests/ert_tests -> tests/unit_tests
  • tests/libres_tests -> tests/unit_tests/c_wrappers

This still leaves some tests in tests/unit_tests that should be in other directories such as tests/integration_tests and tests/gui_tests etc. see #3798.

Issue
Resolves #3798

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@eivindjahren eivindjahren self-assigned this Oct 10, 2022
@eivindjahren eivindjahren force-pushed the reorganize_more_tests branch 18 times, most recently from c007261 to b52c192 Compare October 11, 2022 13:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #4030 (b9103ba) into main (3fda230) will decrease coverage by 22.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #4030       +/-   ##
===========================================
- Coverage   57.72%   35.52%   -22.20%     
===========================================
  Files         529      127      -402     
  Lines       39726    16953    -22773     
  Branches     3592     3592               
===========================================
- Hits        22930     6022    -16908     
+ Misses      15865     9999     -5866     
- Partials      931      932        +1     
Impacted Files Coverage Δ
src/clib/lib/res_util/block_fs.cpp 66.25% <0.00%> (-0.42%) ⬇️
src/ert/ensemble_evaluator/util/_tool.py
src/ert/_c_wrappers/config/config_error.py
...d/ide/keywords/definitions/proper_name_argument.py
.../ide/keywords/definitions/range_string_argument.py
src/ert/_c_wrappers/job_queue/job_queue_node.py
src/ert/_c_wrappers/enkf/config/summary_config.py
src/ert/serialization/__init__.py
.../_c_wrappers/enkf/enums/gen_data_file_type_enum.py
src/ert/shared/plugins/hook_specifications/jobs.py
... and 393 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eivindjahren eivindjahren force-pushed the reorganize_more_tests branch 6 times, most recently from 1fdfdd8 to 271923e Compare October 12, 2022 09:46
Copy link
Contributor

@pinkwah pinkwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌕

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@eivindjahren
Copy link
Contributor Author

jenkins test this please

@eivindjahren eivindjahren force-pushed the reorganize_more_tests branch 9 times, most recently from d656f74 to 85b3e55 Compare October 18, 2022 06:39
There is no longer a split between ert and libres. The test directories
should reflect that. This commit does the following renames

* tests/ert_tests -> tests/unit_tests
* tests/libres_tests -> tests/unit_tests/c_wrappers

Also, this reorganizes the requires_window_manager scheme to
automatically mark tests using qtbot.
@eivindjahren eivindjahren merged commit 1938cdf into equinor:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize tests
3 participants