-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tests directories #4030
Merged
eivindjahren
merged 3 commits into
equinor:main
from
eivindjahren:reorganize_more_tests
Oct 18, 2022
Merged
Rename tests directories #4030
eivindjahren
merged 3 commits into
equinor:main
from
eivindjahren:reorganize_more_tests
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
reorganize_more_tests
branch
18 times, most recently
from
October 11, 2022 13:02
c007261
to
b52c192
Compare
Codecov Report
@@ Coverage Diff @@
## main #4030 +/- ##
===========================================
- Coverage 57.72% 35.52% -22.20%
===========================================
Files 529 127 -402
Lines 39726 16953 -22773
Branches 3592 3592
===========================================
- Hits 22930 6022 -16908
+ Misses 15865 9999 -5866
- Partials 931 932 +1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eivindjahren
force-pushed
the
reorganize_more_tests
branch
6 times, most recently
from
October 12, 2022 09:46
1fdfdd8
to
271923e
Compare
pinkwah
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌕
eivindjahren
force-pushed
the
reorganize_more_tests
branch
from
October 12, 2022 10:32
271923e
to
a263b14
Compare
eivindjahren
force-pushed
the
reorganize_more_tests
branch
from
October 12, 2022 10:41
a263b14
to
c5d1683
Compare
eivindjahren
force-pushed
the
reorganize_more_tests
branch
from
October 13, 2022 11:34
c5d1683
to
a539f85
Compare
jenkins test this please |
eivindjahren
force-pushed
the
reorganize_more_tests
branch
9 times, most recently
from
October 18, 2022 06:39
d656f74
to
85b3e55
Compare
There is no longer a split between ert and libres. The test directories should reflect that. This commit does the following renames * tests/ert_tests -> tests/unit_tests * tests/libres_tests -> tests/unit_tests/c_wrappers Also, this reorganizes the requires_window_manager scheme to automatically mark tests using qtbot.
eivindjahren
force-pushed
the
reorganize_more_tests
branch
from
October 18, 2022 08:43
85b3e55
to
ddf47aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no longer a split between ert and libres. The test directories should reflect that. This PR does the following renames
This still leaves some tests in
tests/unit_tests
that should be in other directories such astests/integration_tests
andtests/gui_tests
etc. see #3798.Issue
Resolves #3798
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.