Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libecl RNG with numpy.random.Generator #4033

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Oct 10, 2022

All sampling is now done in Python. This means we can replace the old crusty RNG implementation with a standardised and well-tested implementation.

Resolves: #4014
Resolves: #2351

@pinkwah pinkwah self-assigned this Oct 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #4033 (5a37968) into main (c7b167b) will increase coverage by 17.44%.
The diff coverage is 67.56%.

@@             Coverage Diff             @@
##             main    #4033       +/-   ##
===========================================
+ Coverage   40.71%   58.16%   +17.44%     
===========================================
  Files         526      526               
  Lines       39347    39305       -42     
  Branches     3562     3554        -8     
===========================================
+ Hits        16021    22862     +6841     
+ Misses      22393    15511     -6882     
+ Partials      933      932        -1     
Impacted Files Coverage Δ
src/clib/lib/analysis/update.cpp 3.17% <ø> (+0.18%) ⬆️
src/clib/lib/enkf/enkf_main.cpp 3.33% <ø> (+0.47%) ⬆️
src/clib/lib/enkf/enkf_node.cpp 1.68% <0.00%> (ø)
src/clib/lib/enkf/enkf_state.cpp 2.18% <0.00%> (-0.54%) ⬇️
src/clib/lib/enkf/field.cpp 0.94% <0.00%> (ø)
src/clib/lib/enkf/gen_data.cpp 26.52% <ø> (ø)
src/clib/lib/include/ert/analysis/update.hpp 0.00% <ø> (ø)
src/clib/lib/include/ert/enkf/enkf_util.hpp 0.00% <0.00%> (ø)
src/clib/lib/enkf/surface.cpp 2.66% <100.00%> (+1.33%) ⬆️
src/ert/_c_wrappers/enkf/enkf_main.py 95.23% <100.00%> (-2.10%) ⬇️
... and 245 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

All sampling is now done in Python. This means we can replace the old
crusty RNG implementation with a standardised and well-tested
implementation.
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍

@pinkwah pinkwah merged commit a97019d into equinor:main Oct 14, 2022
@pinkwah pinkwah deleted the rng branch October 14, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace RNG from ecl with numpy ESUpdate.smootherUpdate results different on osx and ubuntu
3 participants