Move ert.job_runner to _ert_job_runner #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix ya style |
eivindjahren
force-pushed
the
speed_up_job_runner
branch
from
0999731
to
b4cecbe
Compare
|
Looks beautiful. The only concern is that of @sondreso regarding having two top level packages. Perhaps he would like to chime in here? |
|
My concern was that there was some workaround required for having multiple top-level packages with skbuild, but if this is OK I don't have any more concerns 😅 |
eivindjahren
force-pushed
the
speed_up_job_runner
branch
from
b4cecbe
to
aed5b1c
Compare
mortalisk
approved these changes
Oct 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #4076 +/- ##
==========================================
- Coverage 58.16% 57.68% -0.49%
==========================================
Files 526 510 -16
Lines 39312 38361 -951
Branches 3554 3444 -110
==========================================
- Hits 22867 22129 -738
+ Misses 15513 15353 -160
+ Partials 932 879 -53
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Importing ert has significant overhead. Therefore we need to make sure job_runner.py does not do that. By avoiding this, the overhead of running job_runner.py goes from 2 seconds to 0.1 seconds.
eivindjahren
force-pushed
the
speed_up_job_runner
branch
from
bd87a77
to
fc6bec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing ert has significant overhead. Therefore we need to make sure job_runner.py does not do that. By avoiding this, the overhead of running job_runner.py goes from 2 seconds to 0.1 seconds. This seems to make the tests run 30 % faster as a consequence because it spawns job_dispatch.py many times.