Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define usage of setuptools_scm in pyproject.toml #4081

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Define usage of setuptools_scm in pyproject.toml #4081

merged 1 commit into from
Oct 26, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Oct 17, 2022 •
edited

Usage from setup.py is deprecated

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@dafeda
Define usage of setuptools_scm in pyproject.toml
752affa 
Usage from setup.py is deprecated
@dafeda dafeda added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 17, 2022
@dafeda dafeda self-assigned this Oct 17, 2022
@oyvindeide
Copy link
Collaborator

Jenkins, test this please

@pinkwah
Copy link
Contributor

pinkwah commented Oct 26, 2022 •
edited

Jenkins test this please 😡

@oyvindeide oyvindeide merged commit 1144c58 into equinor:main Oct 26, 2022
@dafeda dafeda deleted the setuptool_scm branch October 27, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinkwah pinkwah pinkwah approved these changes

Assignees

@dafeda dafeda

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dafeda @oyvindeide @pinkwah