Show restart button when all realisations fail #4113
Conversation
dafeda
added
the
release-notes:bug-fix
| self._initial_realizations_mask, self._completed_realizations_mask | ||
| ) | ||
| ] | ||
| if len(self._completed_realizations_mask) == 0: |
There was a problem hiding this comment.
Can we change this to if self._completed_realizations_mask is None instead, and then have this attribute None from object initialization and also set to None instead of [] in the case of an ErtRunError (which I speculate is happening here?)
There was a problem hiding this comment.
If possible (meaning that the ensemble length is always known) we can also change it to always have the correct length (but it is maybe needed to allow None at init?)
There was a problem hiding this comment.
Can we change this to
if self._completed_realizations_mask is Noneinstead, and then have this attributeNonefrom object initialization and also set toNoneinstead of[]in the case of anErtRunError(which I speculate is happening here?)
We would then also have to change the input argument to BaseRunModel to Optional[List[bool]] = None right?
Not sure we gain that much from using None instead of [] here.
There was a problem hiding this comment.
Right. A zero-length ensemble is always an error in Ert (?) so [] is "free" to be used equivalent to None. It might be cleaner still to use None as [] could be thought of as ok if one believes zero-length ensembles is a thing.
There was a problem hiding this comment.
So, I tried running poly.ert with 0 realisations and when trying to run an ensemble experiment get this crash:
ValueError: Wrong range syntax 0--1
😬
There was a problem hiding this comment.
(but pylint frowns upon if len(list) == 0, do if not list instead.)
There was a problem hiding this comment.
Pylint does not like bare len(list), explicit checks like len(list)==0 are fine according to pep8.
This was considered a bug in pylint:
pylint-dev/pylint#2815
There was a problem hiding this comment.
ah, but pep8 still says that if not list is good in this situation?
There was a problem hiding this comment.
I'm fine with either as long as the bug is fixed.
I've pushed a version that uses if list.
dafeda
force-pushed
the
restart_button
branch
from
3e6338b
to
eaa5a6b
Compare
Issue
Resolves #4112
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.