Propagate qstat options to qstat executable #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
propagate_option_to_qstat
branch
2 times, most recently
from
fb33bf9
to
af8c386
Compare
|
jenkins test this please |
berland
added
bug
release-notes:bug-fix
xjules
reviewed
Oct 27, 2022
xjules
reviewed
Oct 27, 2022
xjules
reviewed
Oct 27, 2022
tests/unit_tests/c_wrappers/res/job_queue/test_job_queue_manager_torque.py
Show resolved
Hide resolved
xjules
reviewed
Oct 27, 2022
tests/unit_tests/c_wrappers/res/job_queue/test_job_queue_manager_torque.py
Show resolved
Hide resolved
* Refactor test code to avoid repetition and toe-stepping NB: Seemingly not possible to manipulate $PATH in the test code as the driver sometimes picks up a wrong qstat executable depending on order of test function order. Worked around by giving an explicit path to the qstat executable in the driver initialization.
berland
force-pushed
the
propagate_option_to_qstat
branch
from
1629f17
to
de087df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #4135
Approach
Do what was the intention of PR #3880
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.