Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make steplength settable again in IES #5075

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Mar 13, 2023

Issue
Resolves #5062

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@dafeda dafeda self-assigned this Mar 13, 2023
@dafeda dafeda mentioned this pull request Mar 13, 2023
5 tasks
@dafeda dafeda added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Mar 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #5075 (c4b2fa0) into main (bca8ad6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5075      +/-   ##
==========================================
+ Coverage   71.85%   71.90%   +0.04%     
==========================================
  Files         393      393              
  Lines       27389    27392       +3     
  Branches     2027     2027              
==========================================
+ Hits        19681    19695      +14     
+ Misses       7140     7129      -11     
  Partials      568      568              
Impacted Files Coverage Δ
src/ert/_c_wrappers/analysis/analysis_module.py 86.59% <ø> (+4.07%) ⬆️
...rc/ert/shared/models/iterated_ensemble_smoother.py 90.69% <100.00%> (+1.08%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda
Copy link
Contributor Author

dafeda commented Mar 14, 2023

I tried writing a GUI test as well, but it is made difficult by the fact that ERT produces different results even when RANDOM_SEED is set. See #5083 for details.

This will need to be solved before writing a GUI test for this. Here's an issue: #5084

@dafeda dafeda changed the title Make steplength settable again in SIES Make steplength settable again in IES Mar 14, 2023
fh.write(
dedent(
"""
ANALYSIS_SELECT IES_ENKF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the RANDOM_SEED not be set in this run?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see that you are using append so that is the reason._

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dafeda dafeda merged commit ac260b0 into equinor:main Mar 14, 2023
@dafeda dafeda deleted the eivind_fix_steplength branch March 14, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Not longer possible to set step_length in SIES
3 participants