Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change weights via method instead of GUI during test #5198

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Apr 3, 2023

Test has been flaky locally on mac and this seems to resolve it.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #5198 (4f8a122) into main (4eb9658) will increase coverage by 12.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #5198       +/-   ##
===========================================
+ Coverage   60.18%   72.37%   +12.19%     
===========================================
  Files         394      394               
  Lines       27436    27436               
  Branches     2007     2007               
===========================================
+ Hits        16512    19858     +3346     
+ Misses      10360     7014     -3346     
  Partials      564      564               

see 116 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better! 👍

Test has been flaky locally on mac and this seems to resolve it.
@dafeda dafeda self-assigned this Apr 3, 2023
@dafeda dafeda added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Apr 3, 2023
@dafeda dafeda merged commit e81505f into equinor:main Apr 3, 2023
33 of 35 checks passed
@dafeda dafeda deleted the esmda_gui branch April 3, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants