Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strange gui case name appearing for each run of EnsembleSmoother #5223

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Apr 12, 2023

Issue
Resolves #5141

Approach
Replace the gui name with current selected case name with a _prior suffix. So if a user runs EnsembleSmoother with the current case set for the default case. after the smoother runs two new cases are created:

  1. default_prior
  2. default_smoother_update

image

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

Replace the `gui` name with current selected case name with a `_prior` suffix
@DanSava DanSava self-assigned this Apr 12, 2023
@DanSava DanSava added release-notes:improvement Automatically categorise as improvement in release notes release-notes:bug-fix Automatically categorise as bug fix in release notes and removed release-notes:improvement Automatically categorise as improvement in release notes labels Apr 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #5223 (a8cab2f) into main (b5de566) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5223   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files         394      394           
  Lines       27439    27439           
  Branches     2007     2007           
=======================================
  Hits        19851    19851           
  Misses       7024     7024           
  Partials      564      564           
Impacted Files Coverage Δ
src/ert/gui/simulation/ensemble_smoother_panel.py 95.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andreas-el andreas-el self-requested a review April 13, 2023 06:33
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fair solution. Undoubtedly better than what was already there. 👍

@DanSava DanSava merged commit 75f2121 into equinor:main Apr 13, 2023
35 checks passed
@DanSava DanSava deleted the fix_gui_case_appearing branch April 13, 2023 07:45
@andreas-el andreas-el mentioned this pull request Apr 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected case "gui"
3 participants