Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect config errors before displaying #5235

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Apr 17, 2023

Issue
Towards #5099

Approach
Short description of the approach

image
image

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@eivindjahren eivindjahren force-pushed the collect_errors branch 3 times, most recently from 541b6fb to 66e05f7 Compare April 17, 2023 11:52
@eivindjahren eivindjahren force-pushed the collect_errors branch 8 times, most recently from d83145d to bb4f3cc Compare April 18, 2023 08:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #5235 (db27f5b) into main (dcad416) will increase coverage by 0.01%.
The diff coverage is 88.49%.

❗ Current head db27f5b differs from pull request most recent head 49cce9f. Consider uploading reports for the commit 49cce9f to get more accurate results

@@            Coverage Diff             @@
##             main    #5235      +/-   ##
==========================================
+ Coverage   73.18%   73.19%   +0.01%     
==========================================
  Files         391      391              
  Lines       26875    26946      +71     
  Branches     1965     1965              
==========================================
+ Hits        19668    19723      +55     
- Misses       6643     6659      +16     
  Partials      564      564              
Impacted Files Coverage Δ
src/ert/__main__.py 78.92% <0.00%> (ø)
src/ert/_c_wrappers/config/config_parser.py 94.52% <ø> (ø)
src/ert/_c_wrappers/enkf/ert_config.py 95.60% <85.00%> (-2.60%) ⬇️
src/ert/_c_wrappers/enkf/enkf_obs.py 87.37% <100.00%> (-0.13%) ⬇️
src/ert/_c_wrappers/job_queue/ext_job.py 99.41% <100.00%> (+0.56%) ⬆️
src/ert/gui/main.py 90.90% <100.00%> (-0.91%) ⬇️
src/ert/parsing/config_errors.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eivindjahren eivindjahren added the release-notes:improvement Automatically categorise as improvement in release notes label Apr 18, 2023
@eivindjahren eivindjahren self-assigned this Apr 18, 2023
@eivindjahren eivindjahren marked this pull request as ready for review April 18, 2023 10:16
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@eivindjahren eivindjahren force-pushed the collect_errors branch 2 times, most recently from 44142c9 to db27f5b Compare April 18, 2023 12:08
@eivindjahren eivindjahren merged commit abd5035 into equinor:main Apr 18, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants