Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for missing response #5274

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Apr 25, 2023

Issue
Resolves #4990

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@dafeda dafeda self-assigned this Apr 25, 2023
@dafeda dafeda added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Apr 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5274 (3af200a) into main (e219980) will increase coverage by 11.99%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5274       +/-   ##
===========================================
+ Coverage   73.21%   85.21%   +11.99%     
===========================================
  Files         391      338       -53     
  Lines       26938    20205     -6733     
  Branches     1965        0     -1965     
===========================================
- Hits        19724    17217     -2507     
+ Misses       6650     2988     -3662     
+ Partials      564        0      -564     
Impacted Files Coverage Δ
src/ert/analysis/_es_update.py 86.07% <100.00%> (+0.15%) ⬆️
src/ert/storage/local_ensemble.py 95.28% <100.00%> (+0.01%) ⬆️

... and 54 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda force-pushed the frode-fix-test-for-missing-response branch from 3af200a to e5d569d Compare April 25, 2023 09:42
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dafeda dafeda merged commit 3b985f3 into equinor:main Apr 25, 2023
41 of 42 checks passed
@dafeda dafeda deleted the frode-fix-test-for-missing-response branch April 25, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test for missing response for observations does not work
4 participants