Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the queue_query timeout in Torque driver #5297

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

berland
Copy link
Contributor

@berland berland commented Apr 26, 2023

Adding 64 seconds .

62 seconds have been proven occasionally to be insufficient.

Issue
Possibly resolves flakyness whenever the PBS queue system in Azure has a bad moment.

Approach
Increase timeout

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

62 seconds have been proven occasionally to be insufficient.
@berland berland added the release-notes:misc Automatically categorise as miscellaneous change in release notes label Apr 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #5297 (461b1d4) into main (fca5b57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5297   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files         395      395           
  Lines       27137    27137           
  Branches     1969     1969           
=======================================
  Hits        19880    19880           
  Misses       6693     6693           
  Partials      564      564           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@berland berland self-assigned this Apr 26, 2023
Copy link
Contributor

@hnformentin hnformentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly you updated the documentation, so the box could be checked. Is it correct?

Do you know if we have control of all timeouts we increased in order to reduce flakyness in Aure/github actions?

Copy link
Contributor

@hnformentin hnformentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code need to be changed I think, but please reply the comments :-)
Thanks!

@berland
Copy link
Contributor Author

berland commented Apr 27, 2023

If I understood correctly you updated the documentation, so the box could be checked. Is it correct?

Correct! Fixed.

Do you know if we have control of all timeouts we increased in order to reduce flakyness in Aure/github actions?

I don't think we have a list.

@berland berland merged commit 8804664 into equinor:main Apr 27, 2023
41 of 42 checks passed
@berland berland deleted the bump_torque_timeout branch September 8, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants