-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SCHEDULE_PREDICTION_FILE & GEN_KW PRED #5317
Remove SCHEDULE_PREDICTION_FILE & GEN_KW PRED #5317
Conversation
f473d49
to
d5501e9
Compare
Codecov Report
@@ Coverage Diff @@
## main #5317 +/- ##
==========================================
- Coverage 73.74% 73.72% -0.03%
==========================================
Files 392 392
Lines 26787 26768 -19
Branches 2088 2086 -2
==========================================
- Hits 19754 19734 -20
- Misses 6358 6359 +1
Partials 675 675
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Removes obsoleted SCHEDULE_PREDICTION_FILE keyword. Provide warning that GEN_KW PRED does not hold any special meaning anymore and that all GEN_KWs will be treated (updated) similar. Remove residue schedule_file from ensemble_config Refs. Removal of PRED special case: equinor#3820 Alternative way to configure update step: equinor#3859
d5501e9
to
08dc1e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 🥇
Issue
Resolves #4397
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.