Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCHEDULE_PREDICTION_FILE & GEN_KW PRED #5317

Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Apr 28, 2023

Issue
Resolves #4397

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@andreas-el andreas-el force-pushed the remove_schedule_prediction_file branch from f473d49 to d5501e9 Compare May 2, 2023 07:14
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label May 2, 2023
@andreas-el andreas-el changed the title Remove schedule prediction file Remove SCHEDULE_PREDICTION_FILE and GEN_KW PRED May 2, 2023
@andreas-el andreas-el changed the title Remove SCHEDULE_PREDICTION_FILE and GEN_KW PRED Remove SCHEDULE_PREDICTION_FILE & GEN_KW PRED May 2, 2023
@andreas-el andreas-el requested a review from oyvindeide May 2, 2023 07:15
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #5317 (d5501e9) into main (a0c70ca) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5317      +/-   ##
==========================================
- Coverage   73.74%   73.72%   -0.03%     
==========================================
  Files         392      392              
  Lines       26787    26768      -19     
  Branches     2088     2086       -2     
==========================================
- Hits        19754    19734      -20     
- Misses       6358     6359       +1     
  Partials      675      675              
Impacted Files Coverage Δ
src/clib/lib/config/config_keywords.cpp 0.00% <ø> (ø)
src/clib/lib/enkf/config_keys.cpp 0.00% <ø> (ø)
...rc/ert/_c_wrappers/enkf/_config_content_as_dict.py 98.21% <ø> (-0.12%) ⬇️
src/ert/parsing/config_keywords.py 99.33% <ø> (-0.01%) ⬇️
..._wrappers/enkf/_deprecation_migration_suggester.py 98.57% <100.00%> (+0.04%) ⬆️
src/ert/_c_wrappers/enkf/ensemble_config.py 95.89% <100.00%> (-0.90%) ⬇️
.../shared/hook_implementations/workflows/__init__.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Removes obsoleted SCHEDULE_PREDICTION_FILE keyword.
Provide warning that GEN_KW PRED does not hold any special meaning
anymore and that all GEN_KWs will be treated (updated) similar.
Remove residue schedule_file from ensemble_config

Refs.
Removal of PRED special case:
equinor#3820

Alternative way to configure update step:
equinor#3859
@andreas-el andreas-el force-pushed the remove_schedule_prediction_file branch from d5501e9 to 08dc1e2 Compare May 2, 2023 07:47
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🥇

@andreas-el andreas-el merged commit daea5df into equinor:main May 2, 2023
41 of 42 checks passed
@andreas-el andreas-el deleted the remove_schedule_prediction_file branch May 2, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated SCHEDULE_PREDICTION_FILE - not before May 2023
4 participants