Add some more logging #5321
Merged
Add some more logging #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
added
release-notes:skip
Codecov Report
@@ Coverage Diff @@
## main #5321 +/- ##
==========================================
+ Coverage 73.72% 73.77% +0.04%
==========================================
Files 392 392
Lines 26787 26809 +22
Branches 2088 2086 -2
==========================================
+ Hits 19750 19778 +28
+ Misses 6362 6356 -6
Partials 675 675
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dafeda
reviewed
May 2, 2023
| @@ -66,12 +71,15 @@ def load(self, run_path: Path, real_nr: int, ensemble: EnsembleAccessor): | |||
| trans = self.input_transformation | |||
| data_transformed = field_transform(data, trans) if trans else data | |||
| ensemble.save_field(key, real_nr, data_transformed) | |||
| _logger.debug(f"load() time_used {time.perf_counter() - t}s") | |||
There was a problem hiding this comment.
Should we reduce the resolution a bit here?
Perhaps something like:
_logger.debug(f"load() time_used {(time.perf_counter() - t):.4f}s")There was a problem hiding this comment.
Yeas - any more digits does not make any sense
dafeda
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5276
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.