Allow quoted substrings as part of the FORWARD_MODEL arglist in new parser #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSava
force-pushed
the
forward_model_arg_list_new_parser
branch
from
86a058d
to
8bdb5ca
Compare
oysteoh
reviewed
May 5, 2023
| @@ -92,11 +92,12 @@ def test_parsing_forward_model_with_quotes_does_not_introduce_spaces(): | |||
| comment interpretation, quotation marks are used""" | |||
|
|
|||
| test_config_file_name = "test.ert" | |||
| str_with_quotes = 'smt/<foo>"/bar"/xx/"t--s.s"/yy/"z/z"/oo' | |||
There was a problem hiding this comment.
is it relevant to account for "smt/<foo>'/bar'/xx/'t--s.s'/yy/'z/z'/oo" as well?
There was a problem hiding this comment.
That is a good question, I thought about accounting for it, but the old parser does not allow using ' to escape things like 'file--name.txt' so I did not add the functionality.
I can do it for the new parser if you think it is important.
There was a problem hiding this comment.
I have no idea - if the old code didn't allow for it then i suggest we keep your PR as-is 👍👍
DanSava
force-pushed
the
forward_model_arg_list_new_parser
branch
from
8bdb5ca
to
3f34600
Compare
oysteoh
approved these changes
May 8, 2023
DanSava
force-pushed
the
forward_model_arg_list_new_parser
branch
from
3f34600
to
9db8b07
Compare
DanSava
force-pushed
the
forward_model_arg_list_new_parser
branch
from
9db8b07
to
102b1bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5255
Approach
Allow quoted substrings as part of the FORWARD_MODEL arglist in new parser
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.