Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GEN_DATA and SUMMARY configuration #5344

Merged
merged 30 commits into from
May 16, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented May 5, 2023

Issue
Resolves #5347

Approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@andreas-el andreas-el force-pushed the remove_unusued_gen_data_code branch 2 times, most recently from 4c16f0f to 0f20f88 Compare May 8, 2023 07:15
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #5344 (7f89047) into main (0d589e9) will increase coverage by 0.25%.
The diff coverage is 87.63%.

@@            Coverage Diff             @@
##             main    #5344      +/-   ##
==========================================
+ Coverage   74.72%   74.97%   +0.25%     
==========================================
  Files         392      389       -3     
  Lines       26790    26589     -201     
  Branches     1931     1910      -21     
==========================================
- Hits        20018    19936      -82     
+ Misses       6130     6013     -117     
+ Partials      642      640       -2     
Impacted Files Coverage Δ
src/clib/lib/enkf/enkf_config_node.cpp 0.00% <ø> (ø)
src/clib/lib/enkf/enkf_obs.cpp 9.59% <0.00%> (+0.24%) ⬆️
src/clib/lib/enkf/ensemble_config.cpp 9.80% <0.00%> (+1.47%) ⬆️
src/clib/lib/enkf/gen_common.cpp 0.00% <0.00%> (ø)
src/ert/_c_wrappers/enkf/__init__.py 100.00% <ø> (ø)
src/ert/_c_wrappers/enkf/enums/__init__.py 100.00% <ø> (ø)
src/clib/lib/enkf/obs_vector.cpp 44.94% <66.66%> (+1.61%) ⬆️
src/clib/lib/enkf/gen_obs.cpp 35.86% <75.00%> (-0.88%) ⬇️
src/ert/_c_wrappers/enkf/config/gen_data_config.py 95.74% <94.44%> (+14.26%) ⬆️
src/ert/_c_wrappers/enkf/ensemble_config.py 95.98% <98.52%> (-0.33%) ⬇️
... and 9 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andreas-el andreas-el marked this pull request as ready for review May 8, 2023 07:37
@andreas-el andreas-el force-pushed the remove_unusued_gen_data_code branch 14 times, most recently from 60ba68e to 140fcdf Compare May 12, 2023 09:59
@andreas-el andreas-el changed the title Remove unused code from gen_data Refactor GEN_DATA and SUMMARY configuration May 12, 2023
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label May 12, 2023
@andreas-el andreas-el force-pushed the remove_unusued_gen_data_code branch from 47e1d75 to 20b3dde Compare May 15, 2023 05:59
@andreas-el andreas-el force-pushed the remove_unusued_gen_data_code branch 2 times, most recently from c332b20 to 5b59b05 Compare May 15, 2023 15:50
@andreas-el andreas-el force-pushed the remove_unusued_gen_data_code branch from 5b59b05 to f25e0a2 Compare May 15, 2023 20:20
@andreas-el andreas-el force-pushed the remove_unusued_gen_data_code branch from 0abc877 to 7f89047 Compare May 16, 2023 06:07
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍨

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍨

@andreas-el andreas-el merged commit 36c3993 into equinor:main May 16, 2023
30 of 32 checks passed
@andreas-el andreas-el deleted the remove_unusued_gen_data_code branch October 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor GEN_DATA and SUMMARY configuration
4 participants