Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config path and file name to jobs.json #5374

Merged
merged 1 commit into from
May 11, 2023

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented May 10, 2023

Issue
Resolves #5229

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@DanSava DanSava self-assigned this May 10, 2023
@DanSava DanSava force-pushed the add_back_config_path_to_jobs_json branch 2 times, most recently from 6f38e7d to 9fc7a31 Compare May 10, 2023 10:12
@DanSava DanSava force-pushed the add_back_config_path_to_jobs_json branch from 9fc7a31 to 57dbbc8 Compare May 10, 2023 11:07
@codecov-commenter
Copy link

Codecov Report

Merging #5374 (57dbbc8) into main (961bbd7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5374      +/-   ##
==========================================
+ Coverage   74.90%   74.92%   +0.01%     
==========================================
  Files         391      391              
  Lines       26614    26616       +2     
  Branches     1913     1913              
==========================================
+ Hits        19936    19941       +5     
+ Misses       6013     6010       -3     
  Partials      665      665              
Impacted Files Coverage Δ
src/ert/_c_wrappers/enkf/enkf_main.py 99.11% <ø> (ø)
src/ert/_c_wrappers/enkf/ert_config.py 96.21% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DanSava DanSava merged commit 06ec59f into equinor:main May 11, 2023
37 checks passed
@oysteoh
Copy link
Contributor

oysteoh commented May 11, 2023

could we also backport this fix to current stable and ping Erlend about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<CONFIG_PATH> no longer present in jobs.json
3 participants