Assign all unit tests using snake_oil_case_storage to same xdist thread #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHolba
force-pushed
the
reduce-test-runners
branch
from
b139704
to
7c4fb88
Compare
Codecov Report
@@ Coverage Diff @@
## main #5390 +/- ##
==========================================
+ Coverage 74.69% 74.70% +0.01%
==========================================
Files 392 392
Lines 26785 26785
Branches 1931 1931
==========================================
+ Hits 20008 20011 +3
+ Misses 6135 6132 -3
Partials 642 642 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JHolba
force-pushed
the
reduce-test-runners
branch
2 times, most recently
from
6bda456
to
e73a337
Compare
JHolba
changed the title
JHolba
force-pushed
the
reduce-test-runners
branch
from
e73a337
to
5ff6e81
Compare
increase timeout of test_job_runner_startup_overhead. the changes done by grouping tests seems to make it run slower now.
JHolba
force-pushed
the
reduce-test-runners
branch
from
5ff6e81
to
0e8d362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Several unit tests use snake_oil_case_storage that tries to cache the result of a snake_oil run. This cache is local to each xdist thread. Making sure that all unit tests using this pytest fixture run on the same thread will reduce the amount of times we need to run snake oil.
Approach
group all cases using snake_oil_case_storage in one xdist thread
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.