Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flipping default parser means logging against old #5402

Merged
merged 1 commit into from
May 15, 2023
Merged

Flipping default parser means logging against old #5402

merged 1 commit into from
May 15, 2023

Conversation

eivindjahren
Copy link
Contributor

The logging against new parser should now be logging against old parser.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

andreas-el
andreas-el approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@eivindjahren eivindjahren merged commit 8a95abd into equinor:main May 15, 2023
31 of 32 checks passed
@eivindjahren eivindjahren deleted the fix_log_difference branch May 15, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-el andreas-el andreas-el approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eivindjahren @andreas-el