Explicitly use mixed format when converting to dates, avoiding warning #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using mixed parsing seems safest for now. In the poly-case, a warning will be emitted (because inferral of the format does not work when everything is non-dates) unless this option is set
berland
added
the
release-notes:maintenance
berland
changed the title
|
Tested 'Create plot' both in poly-example (no dates) and in the snake-oil example (has dates). Everything looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using mixed parsing seems safest for now. In the poly-case, a warning will be emitted (because inferral of the format does not work when everything is non-dates) unless this option is set
Issue
Resolves #5416
Approach
Set the option
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.