Remove config-node-meta structure, ErtImplType & EnkfVarType enums #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
added
the
release-notes:maintenance
andreas-el
force-pushed
the
refactor_config_node_meta
branch
5 times, most recently
from
aa55040
to
55c7aaf
Compare
The EnkfVarType enum was only used to locate parameters meaning GenKwConfig, SurfaceConfig, ExtParamConfig and FieldConfig This can be done differently, and the enum is no longer needed
andreas-el
force-pushed
the
refactor_config_node_meta
branch
from
55c7aaf
to
c934f25
Compare
andreas-el
force-pushed
the
refactor_config_node_meta
branch
from
7448fdc
to
8327662
Compare
DanSava
reviewed
May 23, 2023
andreas-el
changed the title
andreas-el
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5445
Resolves #5446
Fixup for Semeio
equinor/semeio#519
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.