Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration fails gracefully #5532

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Migration fails gracefully #5532

merged 1 commit into from
Jun 6, 2023

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Jun 5, 2023

Add a try-catch wrapper around migration that logs the error and continues.

Resolve: #5530

Add a try-catch wrapper around migration that logs the error and continues.
@codecov-commenter
Copy link

Codecov Report

Merging #5532 (38b7932) into main (c16c917) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #5532      +/-   ##
==========================================
- Coverage   77.06%   77.05%   -0.02%     
==========================================
  Files         395      395              
  Lines       25893    25898       +5     
  Branches     1760     1760              
==========================================
  Hits        19955    19955              
- Misses       5352     5357       +5     
  Partials      586      586              
Impacted Files Coverage Δ
src/ert/storage/migration/block_fs.py 22.22% <16.66%> (-0.08%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pinkwah pinkwah self-assigned this Jun 5, 2023
@pinkwah
Copy link
Contributor Author

pinkwah commented Jun 5, 2023

NOT tested on Drogon.

@pinkwah pinkwah merged commit e19173f into equinor:main Jun 6, 2023
37 checks passed
@pinkwah pinkwah deleted the unhappy-path branch June 6, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating storage fails on Drogon
3 participants