Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused facade functions #5554

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jun 7, 2023

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jun 7, 2023
@oyvindeide oyvindeide self-assigned this Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #5554 (8771b12) into main (ad28deb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5554   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files         394      394           
  Lines       25649    25645    -4     
  Branches     1761     1761           
=======================================
- Hits        19730    19728    -2     
+ Misses       5331     5329    -2     
  Partials      588      588           
Impacted Files Coverage Δ
src/ert/libres_facade.py 89.70% <ø> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide enabled auto-merge (rebase) June 7, 2023 12:42
@oyvindeide oyvindeide merged commit 7ac732e into equinor:main Jun 7, 2023
37 checks passed
@oyvindeide oyvindeide deleted the unused_facade branch June 7, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants