Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where log values were not included in facade function for gen kw #5643

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

oyvindeide
Copy link
Collaborator

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jun 28, 2023
@oyvindeide oyvindeide self-assigned this Jun 28, 2023
@@ -1,11 +1,11 @@
Realization,PARAM_2:MY_KEYWORD,PARAM_1:MY_KEYWORD
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update the whole snapshot because I changed the parameter from NORMAL -> LOGUNIF. I created the snapshot on version 4.5 to make sure nothing changed.

@codecov-commenter
Copy link

Codecov Report

Merging #5643 (34d5d1d) into main (6c53318) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5643      +/-   ##
==========================================
- Coverage   77.10%   77.09%   -0.02%     
==========================================
  Files         394      394              
  Lines       25825    25831       +6     
  Branches     1740     1740              
==========================================
+ Hits        19913    19914       +1     
- Misses       5336     5341       +5     
  Partials      576      576              
Impacted Files Coverage Δ
src/ert/libres_facade.py 88.80% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@frode-aarstad frode-aarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyvindeide oyvindeide merged commit 3459fbd into equinor:main Jun 29, 2023
37 checks passed
@oyvindeide oyvindeide deleted the log_df branch June 29, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants