Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing observations #5658

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

oyvindeide
Copy link
Collaborator

Issue
Resolves #5617

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

After this missing responses for observations are allowed, and ert
will only throw an error if there are no more observations left
when doing an update. This brings it more in line with version 4
where GEN_OBS was allowed to be missing, but not SUMMARY. Now they
are treated equally. If one response is missing for one realization
that is enough for the observation to be considered missing.
@oyvindeide oyvindeide merged commit fbb0d64 into equinor:main Jun 30, 2023
33 of 34 checks passed
@oyvindeide oyvindeide deleted the allow_obs_mismatch branch June 30, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow missing observations for update
2 participants