Cover previously unhandled job queue state JOB_QUEUE_DO_KILL_NODE_FAILURE
#5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-krasontovitsch
added
the
release-notes:bug-fix
Codecov Report
@@ Coverage Diff @@
## main #5667 +/- ##
==========================================
- Coverage 80.20% 80.18% -0.02%
==========================================
Files 373 373
Lines 23280 23280
Branches 1066 1066
==========================================
- Hits 18671 18667 -4
- Misses 4333 4337 +4
Partials 276 276
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oysteoh
reviewed
Jul 3, 2023
berland
approved these changes
Jul 11, 2023
Possibly due to network issues, sometimes a job cannot be confirmed as running based on the existence of the `STATUS` file, even though it is running. We increase the timeout before we decide that the job is unsavable to be more tolerant of the network. Cf. equinor#4809
The state `JOB_QUEUE_NODE_DO_KILL_NODE_FAILURE` arises when a job has been submitted and should be running, but cannot be confirmed as running based on the `STATUS` file after a certain waiting period. It was previously unhandled in python code, and led to a unexpected job status exception - which would e.g. in ESMDA lead to a node failure when trying to consequently go on with the realization in question. We remedy this by calling the exit callback, which should make sure that there are no failures downstream. Cf. equinor#4809
valentin-krasontovitsch
force-pushed
the
4809-job-queue-unhandled-state
branch
from
06623ea
to
bb3c473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Possibly resolved #4809
Approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.