Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in es-mda where returned variable could potentially be unbound #5683

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

oyvindeide
Copy link
Collaborator

Posterior context could potentially be unbound, so return the prior context instead. The last thing that happens in the loop is to set prior_context = posterior_context, so the result should be the same.

Issue
Resolves #4754

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

Posterior context could potentially be unbound, so return
the prior context instead. The last thing that happens in the loop
is to set prior_context = posterior_context, so the result
should be the same.
@oyvindeide oyvindeide changed the title Return prior context Fix bug in es-mda where returned variable could potentially be unbound Jul 5, 2023
@oyvindeide oyvindeide requested a review from pinkwah July 5, 2023 15:08
Copy link
Contributor

@pinkwah pinkwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert!

@oyvindeide oyvindeide merged commit 5e3bb90 into equinor:main Jul 6, 2023
34 checks passed
@oyvindeide oyvindeide deleted the return_prior branch July 6, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES-MDA, setting --starting-iteration results in posterior_context not being bound
2 participants