Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActiveList #5695

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Remove ActiveList #5695

merged 2 commits into from
Jul 7, 2023

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Jul 6, 2023

No description provided.

@pinkwah pinkwah force-pushed the update branch 2 times, most recently from 79d070e to dd4c6c7 Compare July 6, 2023 15:21
@pinkwah pinkwah changed the title Remove update.cpp Remove ActiveList Jul 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #5695 (00b2b3a) into main (a56b978) will increase coverage by 0.27%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main    #5695      +/-   ##
==========================================
+ Coverage   79.70%   79.97%   +0.27%     
==========================================
  Files         366      362       -4     
  Lines       22618    22508     -110     
  Branches     1041      989      -52     
==========================================
- Hits        18027    18001      -26     
+ Misses       4319     4239      -80     
+ Partials      272      268       -4     
Impacted Files Coverage Δ
src/ert/_c_wrappers/enkf/enums/__init__.py 100.00% <ø> (ø)
src/ert/analysis/_es_update.py 88.17% <55.55%> (+0.88%) ⬆️
src/ert/_c_wrappers/analysis/configuration.py 92.75% <100.00%> (ø)
src/ert/_c_wrappers/enkf/__init__.py 100.00% <100.00%> (ø)
...t/_c_wrappers/enkf/observations/gen_observation.py 92.85% <100.00%> (-2.15%) ⬇️
..._wrappers/enkf/observations/summary_observation.py 100.00% <100.00%> (+13.33%) ⬆️
src/ert/_c_wrappers/update.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some minor comments that you can take into account if you agree

@pinkwah pinkwah force-pushed the update branch 2 times, most recently from 56fc90b to 062a28e Compare July 7, 2023 10:33
The ActiveList concept has been replaced by a list/set of integers that
may be optional. If None, then it is assumed that all indices are
active. If not-None, then only the integers in the container are active.
@pinkwah pinkwah merged commit ebe2bff into equinor:main Jul 7, 2023
33 of 34 checks passed
@pinkwah pinkwah deleted the update branch July 7, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants