Do no create experiment and case on start-up #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeda
added
the
release-notes:skip
dafeda
force-pushed
the
no_default
branch
2 times, most recently
from
9e886bd
to
29a3575
Compare
dafeda
added
release-notes:bug-fix
This fixes the bug where we end up with two default-cases when running a single experiment. Deactivating current case drop-down list, and initialize-button in initialize from scratch if there are no cases.
oyvindeide
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where we end up with two default-cases when running a single experiment.
I propose we initially set the drop-down list of cases as inactive:
The drop-down list will be set to active when gui updates. The drop-down list stays inactive while the simulation window is open though. This could perhaps be fixed.
Once closed though, the list is updated:
The
Initializebutton in "Initialize from scratch" is now deactivated if there are no cases:Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.