Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve RUNPATH deprecated warnings in generated tests #5820

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 7, 2023

Issue
Resolves #5717

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 7, 2023
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🚀

We should probably refactor the results file _%d logic sometime, now it is always replaced with 0. I remember that it was some legacy reason why it needed to be like that, but I think that has changed now.

@andreas-el
Copy link
Contributor Author

andreas-el commented Aug 7, 2023

Nice one 🚀

We should probably refactor the results file _%d logic sometime, now it is always replaced with 0. I remember that it was some legacy reason why it needed to be like that, but I think that has changed now.

We should take a look at it yes.
The current implementation seem to use REPORT_STEP as input for the value to be replaced in RESULT_FILE. In the case of no REPORT_STEPS defined, value 0 will be used.

@andreas-el andreas-el merged commit ed1ef23 into equinor:main Aug 7, 2023
39 of 42 checks passed
@andreas-el andreas-el deleted the resolve_config_warnings_tests branch August 7, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up test configurations wrt %d
2 participants