Fix an issue with double comments #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
added
the
release-notes:bug-fix
eivindjahren
force-pushed
the
fix_bug_with_double_comments
branch
from
61b527f
to
82ef62d
Compare
eivindjahren
force-pushed
the
fix_bug_with_double_comments
branch
2 times, most recently
from
0be94cc
to
08cd717
Compare
andreas-el
approved these changes
Aug 7, 2023
eivindjahren
force-pushed
the
fix_bug_with_double_comments
branch
2 times, most recently
from
5c2c6e2
to
fe92b6d
Compare
Codecov Report
@@ Coverage Diff @@
## main #5824 +/- ##
==========================================
- Coverage 81.47% 81.43% -0.04%
==========================================
Files 346 346
Lines 21846 21843 -3
Branches 720 720
==========================================
- Hits 17798 17787 -11
- Misses 3795 3803 +8
Partials 253 253
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eivindjahren
force-pushed
the
fix_bug_with_double_comments
branch
3 times, most recently
from
d93c238
to
7eb2bdf
Compare
This means that the new parser does interpret attached double dashes as single words any more, but the old parser never allowed that, so it is unproblematic
eivindjahren
force-pushed
the
fix_bug_with_double_comments
branch
from
7eb2bdf
to
148c7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5819
Resolves #5814
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.