Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve location info in error message #5832

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

eivindjahren
Copy link
Contributor

Issue
Resolves #5815

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@eivindjahren eivindjahren self-assigned this Aug 8, 2023
@eivindjahren eivindjahren added enhancement release-notes:improvement Automatically categorise as improvement in release notes labels Aug 8, 2023
@eivindjahren eivindjahren force-pushed the better_location_message branch 4 times, most recently from 60d354e to 6d679c1 Compare August 8, 2023 09:45
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🚀

@codecov-commenter
Copy link

Codecov Report

Merging #5832 (0265e38) into main (3ca1eb1) will decrease coverage by 4.33%.
The diff coverage is 71.87%.

@@            Coverage Diff             @@
##             main    #5832      +/-   ##
==========================================
- Coverage   85.92%   81.59%   -4.33%     
==========================================
  Files         328      347      +19     
  Lines       19383    21787    +2404     
  Branches        0      715     +715     
==========================================
+ Hits        16654    17778    +1124     
- Misses       2729     3756    +1027     
- Partials        0      253     +253     
Files Changed Coverage Δ
src/ert/config/ert_config.py 94.32% <ø> (ø)
src/ert/config/lint_file.py 30.00% <30.00%> (ø)
src/ert/config/parsing/error_info.py 97.01% <88.23%> (-2.99%) ⬇️
src/ert/__main__.py 81.00% <100.00%> (+1.46%) ⬆️
src/ert/config/__init__.py 100.00% <100.00%> (ø)
src/ert/config/parsing/config_errors.py 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eivindjahren eivindjahren merged commit ab47bba into equinor:main Aug 8, 2023
42 checks passed
@eivindjahren eivindjahren deleted the better_location_message branch August 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Location info should be more clear
3 participants