Refactor JobQueue & JobQueueStatus #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
force-pushed
the
remove_more_queue_related
branch
from
8769fe5
to
a1126c8
Compare
Codecov Report
@@ Coverage Diff @@
## main #5845 +/- ##
==========================================
- Coverage 86.03% 81.72% -4.31%
==========================================
Files 329 347 +18
Lines 19386 21705 +2319
Branches 0 737 +737
==========================================
+ Hits 16678 17738 +1060
- Misses 2708 3714 +1006
- Partials 0 253 +253
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andreas-el
added
the
release-notes:maintenance
andreas-el
force-pushed
the
remove_more_queue_related
branch
from
c962de6
to
63584f9
Compare
andreas-el
changed the title
eivindjahren
reviewed
Aug 9, 2023
src/ert/job_queue/queue.py
Outdated
| @@ -131,19 +129,19 @@ def __init__(self, driver: "Driver", max_submit: int = 2): | |||
|
|
|||
| @property | |||
| def num_running(self) -> int: | |||
| return self._num_running() # type: ignore | |||
| return self._num_jobs(JobStatusType.JOB_QUEUE_RUNNING) # type: ignore | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Turns out that these are only used in __str__ and __repr__ could we just make those standard instead and remove these?
There was a problem hiding this comment.
Can you clarify what you mean with 'standard' in this context?
There was a problem hiding this comment.
I was thinking str the same as repr and repr satisfies https://docs.python.org/3/library/functions.html#repr in a simple way, such as "<JobQueue()>".
andreas-el
force-pushed
the
remove_more_queue_related
branch
3 times, most recently
from
fb3af75
to
e7b1742
Compare
andreas-el
force-pushed
the
remove_more_queue_related
branch
from
dedda37
to
3cff6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #my_issue
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.