Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate field parameter at startup #5869

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

oyvindeide
Copy link
Collaborator

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@codecov-commenter
Copy link

Codecov Report

Merging #5869 (11727c0) into main (18ab918) will increase coverage by 0.05%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5869      +/-   ##
==========================================
+ Coverage   81.71%   81.76%   +0.05%     
==========================================
  Files         347      347              
  Lines       21718    21619      -99     
  Branches      739      737       -2     
==========================================
- Hits        17746    17676      -70     
+ Misses       3719     3690      -29     
  Partials      253      253              
Files Changed Coverage Δ
src/ert/config/ensemble_config.py 95.05% <100.00%> (ø)

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide merged commit 9151ea8 into equinor:main Aug 15, 2023
41 of 42 checks passed
@oyvindeide oyvindeide deleted the fix_field_validation branch August 15, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants