Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that observation error is above 0 at startup #5879

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 16, 2023

Issue
Resolves #3921

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 16, 2023
@oyvindeide oyvindeide self-assigned this Aug 16, 2023
@oyvindeide oyvindeide changed the title Check that observation error is above 0 Validate that observation error is above 0 at startup Aug 16, 2023
This would not crash at startup, but would crash in the posterior
 when trying to write NaN to json.
@oyvindeide oyvindeide enabled auto-merge (rebase) August 16, 2023 08:27
@oyvindeide oyvindeide added release-notes:improvement Automatically categorise as improvement in release notes and removed release-notes:maintenance Automatically categorise as maintenance change in release notes labels Aug 16, 2023
@oyvindeide oyvindeide merged commit 5c68505 into equinor:main Aug 16, 2023
41 of 42 checks passed
@oyvindeide oyvindeide deleted the positive_std branch August 16, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail early when observation error is zero
2 participants