Save response info in storage #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
force-pushed
the
save_response_info
branch
9 times, most recently
from
05397f6
to
1072844
Compare
Codecov Report
@@ Coverage Diff @@
## main #6099 +/- ##
==========================================
+ Coverage 82.49% 82.70% +0.20%
==========================================
Files 350 351 +1
Lines 21455 21540 +85
Branches 839 839
==========================================
+ Hits 17700 17815 +115
+ Misses 3457 3427 -30
Partials 298 298
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oyvindeide
force-pushed
the
save_response_info
branch
10 times, most recently
from
4afec8b
to
14978ab
Compare
pinkwah
reviewed
Sep 25, 2023
pinkwah
approved these changes
Sep 25, 2023
oyvindeide
force-pushed
the
save_response_info
branch
2 times, most recently
from
865a242
to
c1ac285
Compare
This moves all the information about which responses are saved in storage to storage, instead of reading them through the config. The removes the need to pass the ensemble config to the forward model ok function.
This removes some redundant functions and simplifies the mocking as some of it was outdated.
oyvindeide
force-pushed
the
save_response_info
branch
from
c1ac285
to
7d48e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist