Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where truncated normal was not truncated #6110

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 19, 2023

(cherry picked from commit d54ed18)

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov-commenter
Copy link

Codecov Report

Merging #6110 (5d4f9a7) into version-6.0 (3df5ab7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           version-6.0    #6110      +/-   ##
===============================================
- Coverage        81.94%   81.93%   -0.02%     
===============================================
  Files              350      350              
  Lines            21817    21816       -1     
  Branches           737      737              
===============================================
- Hits             17879    17874       -5     
- Misses            3685     3689       +4     
  Partials           253      253              
Files Changed Coverage Δ
src/ert/config/gen_kw_config.py 97.89% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda merged commit ec1a34c into equinor:version-6.0 Sep 19, 2023
42 checks passed
@dafeda dafeda deleted the cherry_truncated branch September 19, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants