Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protobuf #6172

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Remove protobuf #6172

merged 1 commit into from
Sep 28, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 26, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 26, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #6172 (1dc2df5) into main (3ecb021) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6172      +/-   ##
==========================================
- Coverage   82.72%   82.66%   -0.06%     
==========================================
  Files         351      347       -4     
  Lines       21544    21245     -299     
  Branches      834      834              
==========================================
- Hits        17822    17562     -260     
+ Misses       3424     3385      -39     
  Partials      298      298              
Files Coverage Δ
src/ert/__main__.py 81.85% <ø> (+0.24%) ⬆️
src/ert/cli/main.py 92.53% <100.00%> (-1.06%) ⬇️
src/ert/ensemble_evaluator/_builder/_ensemble.py 92.07% <ø> (+1.08%) ⬆️
src/ert/ensemble_evaluator/_builder/_legacy.py 92.78% <100.00%> (+0.78%) ⬆️
src/ert/job_queue/queue.py 90.41% <ø> (+2.28%) ⬆️
src/ert/run_models/base_run_model.py 94.00% <ø> (+<0.01%) ⬆️
src/ert/run_models/ensemble_experiment.py 97.61% <100.00%> (+6.47%) ⬆️
src/ert/shared/feature_toggling.py 89.74% <ø> (-10.26%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda force-pushed the remove_protobuf branch 2 times, most recently from 5dec8d9 to c92362f Compare September 26, 2023 17:45
@dafeda dafeda added the maintenance Not a bug now but could be one day, repaying technical debt label Sep 27, 2023
@dafeda dafeda force-pushed the remove_protobuf branch 2 times, most recently from 4c74441 to 56c89dc Compare September 27, 2023 12:46
@dafeda dafeda marked this pull request as ready for review September 27, 2023 12:47
This removes the prototype of experiment server,
and not used async functions from run models.
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪅

@dafeda dafeda merged commit 664fce7 into equinor:main Sep 28, 2023
40 checks passed
@dafeda dafeda deleted the remove_protobuf branch September 28, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants