Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store observations #6302

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Store observations #6302

merged 7 commits into from
Oct 17, 2023

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Oct 11, 2023

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #6302 (797b37a) into main (d57d133) will increase coverage by 0.00%.
The diff coverage is 97.95%.

@@           Coverage Diff           @@
##             main    #6302   +/-   ##
=======================================
  Coverage   83.80%   83.81%           
=======================================
  Files         342      343    +1     
  Lines       20759    20796   +37     
  Branches      862      862           
=======================================
+ Hits        17398    17430   +32     
- Misses       3062     3067    +5     
  Partials      299      299           
Files Coverage Δ
src/ert/analysis/__init__.py 100.00% <ø> (ø)
src/ert/cli/main.py 92.75% <ø> (ø)
src/ert/config/observation_vector.py 92.68% <100.00%> (+0.37%) ⬆️
src/ert/config/observations.py 94.62% <100.00%> (-0.29%) ⬇️
src/ert/dark_storage/common.py 88.52% <100.00%> (ø)
src/ert/data/_measured_data.py 77.00% <100.00%> (-1.58%) ⬇️
src/ert/gui/ertwidgets/caselist.py 96.96% <ø> (ø)
src/ert/gui/simulation/simulation_panel.py 96.55% <ø> (ø)
src/ert/libres_facade.py 89.25% <100.00%> (+0.24%) ⬆️
src/ert/run_models/iterated_ensemble_smoother.py 94.93% <100.00%> (-0.07%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide force-pushed the store_observations branch 3 times, most recently from b8af2d9 to c4e54c5 Compare October 13, 2023 11:32
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oyvindeide oyvindeide force-pushed the store_observations branch 3 times, most recently from 797b37a to 993a74c Compare October 17, 2023 08:25
@oyvindeide oyvindeide self-assigned this Oct 17, 2023
@oyvindeide oyvindeide force-pushed the store_observations branch 2 times, most recently from 15f737d to 7f70bb8 Compare October 17, 2023 12:14
@oyvindeide oyvindeide added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Oct 17, 2023
@oyvindeide oyvindeide merged commit 1b2f03f into equinor:main Oct 17, 2023
43 of 44 checks passed
@oyvindeide oyvindeide deleted the store_observations branch October 17, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants