Implement streaming algorithm #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeda
added
improvement
Codecov Report
@@ Coverage Diff @@
## main #6316 +/- ##
==========================================
- Coverage 82.68% 82.65% -0.04%
==========================================
Files 347 347
Lines 21330 21338 +8
Branches 862 862
==========================================
Hits 17637 17637
- Misses 3394 3402 +8
Partials 299 299
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dafeda
force-pushed
the
streaming_algo
branch
from
060f77a
to
643b70c
Compare
dafeda
force-pushed
the
streaming_algo
branch
2 times, most recently
from
8ffd6d9
to
d0bd32c
Compare
frode-aarstad
approved these changes
Oct 16, 2023
Instead of loading all parameter groups into memory before updating, the streaming algorithm loads one parameter group into memory, updates it, and writes it back to disk. This is particularly useful when multiple large fields are updated.
dafeda
force-pushed
the
streaming_algo
branch
from
d0bd32c
to
613d1fe
Compare
|
Based on input from @oyvindeide , I have removed the usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading all parameter groups into memory before updating, the streaming algorithm loads one parameter group into memory, updates it, and writes it back to disk.
This is particularly useful when multiple large fields are updated.
Issue
Resolves #5905
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist