Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test adaptive localization with cut-off 0 and 1 #6318

Merged
merged 1 commit into from Oct 17, 2023

Conversation

kvashchuka
Copy link
Contributor

@kvashchuka kvashchuka commented Oct 13, 2023

Issue
Resolves #6223, resolves #6222

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find these tests to be very easy to read and understand. 👍
Good if @oyvindeide takes a look as well I think.

Co-authored by: Berent Å. S. Lunde <lundeberent@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #6318 (c437e48) into localization (270170c) will decrease coverage by 0.96%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           localization    #6318      +/-   ##
================================================
- Coverage         83.66%   82.70%   -0.96%     
================================================
  Files               342      347       +5     
  Lines             20826    21457     +631     
  Branches            862      862              
================================================
+ Hits              17424    17746     +322     
- Misses             3103     3413     +310     
+ Partials            299      298       -1     

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kvashchuka kvashchuka merged commit c8fa508 into equinor:localization Oct 17, 2023
44 checks passed
@kvashchuka kvashchuka deleted the test_al_cutoff1 branch October 17, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants