Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies run models by removing statefullness and replacing with arguments #6398

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Oct 23, 2023

Issue
Removes some statefulness from the run models

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

Codecov Report

Merging #6398 (6ee9a9c) into main (1b858eb) will decrease coverage by 0.03%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main    #6398      +/-   ##
==========================================
- Coverage   83.35%   83.33%   -0.03%     
==========================================
  Files         343      343              
  Lines       20863    20857       -6     
  Branches      911      911              
==========================================
- Hits        17391    17381      -10     
- Misses       3186     3191       +5     
+ Partials      286      285       -1     
Files Coverage Δ
src/ert/cli/model_factory.py 96.82% <ø> (ø)
src/ert/enkf_main.py 100.00% <100.00%> (ø)
.../gui/tools/manage_cases/case_init_configuration.py 96.26% <100.00%> (-0.14%) ⬇️
src/ert/run_models/base_run_model.py 94.46% <100.00%> (ø)
src/ert/run_models/ensemble_experiment.py 97.82% <ø> (ø)
src/ert/run_models/ensemble_smoother.py 100.00% <ø> (ø)
src/ert/run_models/iterated_ensemble_smoother.py 94.87% <100.00%> (-0.13%) ⬇️
src/ert/run_models/multiple_data_assimilation.py 89.10% <ø> (ø)
src/ert/run_models/run_arguments.py 100.00% <100.00%> (ø)
...rc/ert/gui/tools/run_analysis/run_analysis_tool.py 79.43% <66.66%> (-0.57%) ⬇️
... and 1 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide force-pushed the simplfy_runmodels branch 2 times, most recently from 90b4b44 to 6ac8a1c Compare October 24, 2023 07:51
@oyvindeide oyvindeide self-assigned this Oct 24, 2023
@oyvindeide oyvindeide marked this pull request as ready for review October 24, 2023 07:52
@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Oct 24, 2023
@oyvindeide oyvindeide merged commit 08185fa into equinor:main Oct 24, 2023
44 checks passed
@oyvindeide oyvindeide deleted the simplfy_runmodels branch October 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants