Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote shell issue with new tmpfile behavior #6421

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix remote shell issue with new tmpfile behavior #6421

merged 2 commits into from
Oct 25, 2023

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 25, 2023 •
edited

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@eivindjahren
Revert "Revert "Avoid using util_alloc_temp_file""
aec9975 
This reverts commit 9112413.
@eivindjahren
Fix issue with remote shell
230bb87 
The problem was that '%s' was put into the remote command,
causing remote shell to say 'fg: no job control' as %
is a shell prefix command requiring job control.
@eivindjahren eivindjahren changed the title Fml Fix remote shell issue with new tmpfile behavior Oct 25, 2023
berland
berland approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch %s :)

@eivindjahren eivindjahren merged commit ea1e668 into equinor:main Oct 25, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eivindjahren @berland