Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create one EnKFMain per run model #6536

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Create one EnKFMain per run model #6536

merged 6 commits into from
Nov 15, 2023

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 9, 2023 •
edited

Issue
Removes some state from the run models.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@oyvindeide oyvindeide self-assigned this Nov 9, 2023
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 9, 2023
@oyvindeide oyvindeide force-pushed the remove_some_enkf branch 6 times, most recently from 7c0647c to dabf409 Compare November 10, 2023 21:10
@oyvindeide oyvindeide changed the title Replace EnKFMain with ErtConfig where it makes sense Create one EnKFMain per run model Nov 14, 2023
sondreso
sondreso approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good step in the right direction!

@oyvindeide oyvindeide force-pushed the remove_some_enkf branch 2 times, most recently from f788b8a to 55d6250 Compare November 15, 2023 14:30
@oyvindeide oyvindeide enabled auto-merge (rebase) November 15, 2023 14:41
@oyvindeide oyvindeide merged commit 4241702 into equinor:main Nov 15, 2023
43 checks passed
@oyvindeide oyvindeide deleted the remove_some_enkf branch November 16, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees

@oyvindeide oyvindeide

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oyvindeide @sondreso