Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused keyword ENKF_MODE #6568

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Nov 15, 2023

Remove keyword from documentation
Add keyword to just-remove-list

Keyword has not been used last three months, and functionality was removed back in 2019.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el self-assigned this Nov 15, 2023
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d1b2fb) 83.51% compared to head (eff5519) 83.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6568   +/-   ##
=======================================
  Coverage   83.51%   83.51%           
=======================================
  Files         346      346           
  Lines       20764    20764           
  Branches      948      948           
=======================================
  Hits        17341    17341           
  Misses       3129     3129           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 🪐

Remove keyword from documentation
Add keyword to just-remove-list
@andreas-el andreas-el merged commit fccc460 into equinor:main Nov 15, 2023
44 checks passed
@andreas-el andreas-el deleted the remove_enkf_mode_unused branch November 15, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants